This repository has been archived by the owner on Nov 1, 2018. It is now read-only.
Update SqliteCommand.Prepare implementation #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2017
bricelam
commented
Jul 20, 2017
| } | ||
| catch | ||
| { | ||
| if (unprepared) |
There was a problem hiding this comment.
Will update to catch..when.
bricelam
commented
Jul 20, 2017
| throw new InvalidOperationException(Resources.SetRequiresNoOpenReader(nameof(CommandText))); | ||
| } | ||
|
|
||
| if (!value.Equals(_commandText)) |
There was a problem hiding this comment.
Possible null ref. Will update.
bricelam
commented
Jul 20, 2017
| @@ -198,4 +198,10 @@ | |||
| <data name="CannotStoreNaN" xml:space="preserve"> | |||
| <value>Cannot store 'NaN' values.</value> | |||
| </data> | |||
| <data name="DataReaderOpen" xml:space="preserve"> | |||
| <value>An open DataReader is already associated with this command. Close it before opening a new one.</value> | |||
There was a problem hiding this comment.
Should be data reader.
bricelam
commented
Jul 20, 2017
| var rc = raw.sqlite3_prepare_v2( | ||
| _connection.Handle, | ||
| tail, | ||
| out sqlite3_stmt stmt, |
smitpatel
approved these changes
Jul 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8e4db99 improves on the previous implementation we tried.
I ran a quick benchmark reusing a parameterized
INSERTcommand for fun: 4x faster!Resolves #235
/cc @AlexanderTaeschner