Skip to content
This repository has been archived by the owner. It is now read-only.

changed GetFormat of FormatFilter to virtual #4483

Closed
wants to merge 1 commit into from

Conversation

@filipw
Copy link
Contributor

commented Apr 15, 2016

Allows me to use a custom query string (instead of the hardcoded format) or extract format in any other funky way from the ActionContext.

I can now subclass FormatFilter with my own implementation of GetFormat, register this custom implementation in the DI and then have FormatFilterAttribute pick it up automatically.

@dnfclas

This comment has been minimized.

Copy link

commented Apr 15, 2016

Hi @filipw, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@filipw filipw changed the title changed GetFormat to virtual changed GetFormat of FormatFilter to virtual Apr 15, 2016

@Eilon Eilon assigned dougbu and rynowak and unassigned dougbu Apr 27, 2016

@Eilon

This comment has been minimized.

Copy link
Member

commented Apr 27, 2016

@rynowak can you merge?

@rynowak

This comment has been minimized.

Copy link
Member

commented Apr 28, 2016

Merged f567258

@Eilon

This comment has been minimized.

Copy link
Member

commented May 2, 2016

@rynowak close?

@rynowak

This comment has been minimized.

Copy link
Member

commented May 4, 2016

😁

@rynowak rynowak closed this May 4, 2016

@filipw

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2016

thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.