Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Check for empty location in ViewsFeatureProvider #5685

Merged
merged 1 commit into from Jan 17, 2017
Merged

Check for empty location in ViewsFeatureProvider #5685

merged 1 commit into from Jan 17, 2017

Conversation

pranavkm
Copy link
Contributor

Fixes #5675

@pranavkm
Copy link
Contributor Author

cc @Eilon

@ryanbrandenburg
Copy link
Member

Your code seems pretty straightforward, but I'm wondering under what conditions Assembly.Location would be empty?

@ryanbrandenburg
Copy link
Member

Looks like you're test's failing though.

@pranavkm
Copy link
Contributor Author

🆙 📅 According to the bug, the location is null when an assembly is loaded from a stream.

@pranavkm pranavkm merged commit e749a80 into dev Jan 17, 2017
@pranavkm pranavkm deleted the prkrishn/5675 branch January 17, 2017 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Eilon Eilon Eilon approved these changes

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pranavkm @ryanbrandenburg @Eilon @dnfclas