This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Add Remove(string key, out object value) overload to RouteValueDictionary #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Oct 17, 2018
| return false; | ||
| } | ||
|
|
||
| EnsureCapacity(Count); |
Member
There was a problem hiding this comment.
Add a comment that this is called for the side-effect.
rynowak
reviewed
Oct 17, 2018
| ThrowArgumentNullExceptionForKey(); | ||
| } | ||
|
|
||
| if (Count == 0) |
Member
There was a problem hiding this comment.
nit: there's lots of mixing of Count and _count here. Does it make sense to use a local and update at the end?
Contributor
Author
There was a problem hiding this comment.
I updated the new Remove overload to consistently use the _count field.
Note that there's a mix throughout this class.
rynowak
reviewed
Oct 17, 2018
| Assert.Empty(dict); | ||
| Assert.IsType<KeyValuePair<string, object>[]>(dict._arrayStorage); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
For array storage I'd also like to see tests for the case where the value removed is the first/middle/last
…rloads. Added comment on EnsureCapacity call. Added test for removing first/middle/last entry.
rynowak
added a commit
to aspnet/HttpAbstractions
that referenced
this pull request
Oct 17, 2018
rynowak
added a commit
to aspnet/HttpAbstractions
that referenced
this pull request
Oct 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Remove(string key, out object value)overload to RouteValueDictionary, and use it where applicable.Note that we could also benefit from using the same overload on Dictionary<TKey, TValue> in other places. Unless we use conditional compilation, we cannot use this overload since it's not available in .NET Standard 2.0.