From 4a0ff76b3157c2cf7013b437793318d0e4602ac8 Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Wed, 17 Oct 2018 20:10:50 +1300 Subject: [PATCH] Prefer StringComparison over StringComparer when not using comparers --- .../Internal/LinkGenerationDecisionTree.cs | 5 +++-- .../Matching/HttpMethodMatcherPolicy.cs | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs b/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs index 6242198a..f276bf06 100644 --- a/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs +++ b/src/Microsoft.AspNetCore.Routing/Internal/LinkGenerationDecisionTree.cs @@ -164,9 +164,10 @@ public int Compare(OutboundMatchResult x, OutboundMatchResult y) return x.IsFallbackMatch.CompareTo(y.IsFallbackMatch); } - return StringComparer.Ordinal.Compare( + return string.Compare( x.Match.Entry.RouteTemplate.TemplateText, - y.Match.Entry.RouteTemplate.TemplateText); + y.Match.Entry.RouteTemplate.TemplateText, + StringComparison.Ordinal); } } diff --git a/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs b/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs index b03c307a..f1ec26d6 100644 --- a/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs +++ b/src/Microsoft.AspNetCore.Routing/Matching/HttpMethodMatcherPolicy.cs @@ -285,7 +285,7 @@ private static bool ContainsHttpMethod(List httpMethods, string httpMeth { for (var i = 0; i < httpMethods.Count; i++) { - if (StringComparer.OrdinalIgnoreCase.Equals(httpMethods[i], httpMethod)) + if (string.Equals(httpMethods[i], httpMethod, StringComparison.OrdinalIgnoreCase)) { return true; }