ChallengeContext will be null with [Authorize] attribute #137
Conversation
OpenIdConnect set Ticket.Principal, get identity from there.
There was a problem hiding this comment.
I think this duplication needs to be resolved inside of AuthTicket, we don't want every consumer to have to check both properties.
There was a problem hiding this comment.
OIDC sets the Principal property.
Since changes w.r.t. that property are still in the early development, I agree to change OIDC until we have a comprehensive fix.
There was a problem hiding this comment.
Yea, I just noticed this. No no no no no. You can't just slap a Principal and an Identity property to AuthTicket. This needs reverting before Beta 3 please.
There was a problem hiding this comment.
@blowdart - ClaimsPrincipal was introduced in AuthenticationTicket with OIDC - 49e66f0. @blowdart mentioned in a conversation having both Principal and Identity on AuthenticationTicket is going to confuse users. So until we decide on whether it is Principal or Identity to be in AuthenticationTicket he suggested to remove the Principal property from AuthenticationTicket for beta3.
There was a problem hiding this comment.
@brentschmaltz Is there a reason you needed a full blown principal?
There was a problem hiding this comment.
There was a problem hiding this comment.
use _logger.WriteWarning("{0}", redirectUri ?? "null") overload of logger to substitute parameters.
There was a problem hiding this comment.
We write the same warning in ApplyResponseGrantAsync method in the same file. Just for consistency.
adjust formating of messages.
There was a problem hiding this comment.
Niggle - why are we embedding error codes again? This isn't 1995 any more. If an error message is not explicit enough to make sense without having an error code then the message is no good.
There was a problem hiding this comment.
Oh I assumed that was something standard. If it's just something we made up then please remove it.
ChallengeContext will be null with [Authorize] attribute
6 participants
OpenIdConnect set Ticket.Principal, get identity from there.