This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Code improvements of JwtBearer module #1742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tratcher
reviewed
May 1, 2018
|
|
||
| foreach (var ex in exceptions) | ||
| { | ||
| // Order sensitive, some of these exceptions derive from others |
Member
There was a problem hiding this comment.
Is this comment still relevant? Does the switch select the most specific match in a type hierarchy?
Member
There was a problem hiding this comment.
Nevermind: https://docs.microsoft.com/en-us/dotnet/csharp/pattern-matching
The switch expressions are evaluated in textual order.
Member
|
Thanks |
Contributor
Author
|
Not at all |
HaoK
pushed a commit
that referenced
this pull request
Jul 11, 2018
* Use pattern matching to check exception type in JwtBearerHandler * Use expression body to configure events in JwtBearerHandler
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
JwtBearerHandlerto simplify code