New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish signalr.js on cdnjs.com #1525

Closed
madskristensen opened this Issue Mar 2, 2018 · 24 comments

Comments

Projects
None yet
8 participants
@madskristensen

madskristensen commented Mar 2, 2018

This will enable LibMan to provide the script file so developers don't have to use npm

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 4, 2018

Member

cc @jbagga FYI because she's looked into this for some of our other scripts.

Member

Eilon commented Mar 4, 2018

cc @jbagga FYI because she's looked into this for some of our other scripts.

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 5, 2018

Member

Ugh, I hope we don't get too bogged down publishing to a bunch of different CDNs. If cdnjs is the primary CDN the community uses now, then that's OK. I've just bee using unpkg.com to get files out of the package (though that doesn't really have a proper SLA, so recommending that to customers is probably not idea)

Member

anurse commented Mar 5, 2018

Ugh, I hope we don't get too bogged down publishing to a bunch of different CDNs. If cdnjs is the primary CDN the community uses now, then that's OK. I've just bee using unpkg.com to get files out of the package (though that doesn't really have a proper SLA, so recommending that to customers is probably not idea)

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 5, 2018

Member

We use NPM, CDNJS, and the ASP.NET CDN... for now 😄

Member

Eilon commented Mar 5, 2018

We use NPM, CDNJS, and the ASP.NET CDN... for now 😄

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 5, 2018

Member

for now

That's my concern. I'd rather we just published to NPM as the one authoritative source and use tools to publish off of that. Anyway, however we implement it, I'm not too worried about where we publish as long as we can automate it.

Member

anurse commented Mar 5, 2018

for now

That's my concern. I'd rather we just published to NPM as the one authoritative source and use tools to publish off of that. Anyway, however we implement it, I'm not too worried about where we publish as long as we can automate it.

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 5, 2018

Member

Looks like we qualify for cdnjs based on GitHub stars: https://github.com/cdnjs/cdnjs/blob/master/CONTRIBUTING.md#b-request-a-new-library

Member

anurse commented Mar 5, 2018

Looks like we qualify for cdnjs based on GitHub stars: https://github.com/cdnjs/cdnjs/blob/master/CONTRIBUTING.md#b-request-a-new-library

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 5, 2018

Member

Oh, and some packages need to go to NuGet.org as Content packages, but that applies to stuff that needs to go to old-style CSPROJ's, such as MVC 5.x, Web Forms, etc.

Member

Eilon commented Mar 5, 2018

Oh, and some packages need to go to NuGet.org as Content packages, but that applies to stuff that needs to go to old-style CSPROJ's, such as MVC 5.x, Web Forms, etc.

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 5, 2018

Member

It would be nice to see if we can drive all that from the NPM packages somehow so we only have to produce one set of things out of the repos and then have a tool push those packages to all the places they need to go.

Member

anurse commented Mar 5, 2018

It would be nice to see if we can drive all that from the NPM packages somehow so we only have to produce one set of things out of the repos and then have a tool push those packages to all the places they need to go.

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 5, 2018

Member

Different packages release at a different cadence. E.g. the jQuery unobtrusive validation/ajax stuff ships completely separately from everything else. The SignalR stuff presumably sim-ships with SignalR (and ASP.NET Core and .NET Core).

I'm certainly open to suggestions on anything we can do to make the process easier.

Member

Eilon commented Mar 5, 2018

Different packages release at a different cadence. E.g. the jQuery unobtrusive validation/ajax stuff ships completely separately from everything else. The SignalR stuff presumably sim-ships with SignalR (and ASP.NET Core and .NET Core).

I'm certainly open to suggestions on anything we can do to make the process easier.

@jbagga

This comment has been minimized.

Show comment
Hide comment
@jbagga

jbagga Mar 5, 2018

For cdnjs, adding an npm hook to package.json should allow auto-update. https://github.com/cdnjs/cdnjs/blob/master/documents/autoupdate.md
I don't think publishing to npm can be automated though https://docs.npmjs.com/getting-started/publishing-npm-packages#how-to-update-a-package
Microsoft CDN and NuGet will need to be manual too I am guessing. Package creation for NuGet can be automated with an MSBuild task but not publishing.
Here's the issue I am working on aspnet/jquery-validation-unobtrusive#47

jbagga commented Mar 5, 2018

For cdnjs, adding an npm hook to package.json should allow auto-update. https://github.com/cdnjs/cdnjs/blob/master/documents/autoupdate.md
I don't think publishing to npm can be automated though https://docs.npmjs.com/getting-started/publishing-npm-packages#how-to-update-a-package
Microsoft CDN and NuGet will need to be manual too I am guessing. Package creation for NuGet can be automated with an MSBuild task but not publishing.
Here's the issue I am working on aspnet/jquery-validation-unobtrusive#47

@anurse anurse added the type: Task label Mar 13, 2018

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 13, 2018

Member

This is a release task, we should look at doing it in Preview 2.

Member

anurse commented Mar 13, 2018

This is a release task, we should look at doing it in Preview 2.

@anurse anurse modified the milestones: 2.1.0-preview2, 2.1.0-rc1 Mar 13, 2018

@anurse anurse added the cost: 0 label Mar 16, 2018

@cecilphillip

This comment has been minimized.

Show comment
Hide comment
@cecilphillip

cecilphillip Mar 23, 2018

Just throwing in my 2c here. jsDelivr and UnPkg are two NPM CDNs that I've been using for demos. They're also the recommended CDNs for the VueJS project

cecilphillip commented Mar 23, 2018

Just throwing in my 2c here. jsDelivr and UnPkg are two NPM CDNs that I've been using for demos. They're also the recommended CDNs for the VueJS project

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Mar 23, 2018

Member

@cecilphillip I think we'll need to limit the number of CDNs that we actively publish to in order to keep things manageable, but certainly others can go further with additional CDNs.

Member

Eilon commented Mar 23, 2018

@cecilphillip I think we'll need to limit the number of CDNs that we actively publish to in order to keep things manageable, but certainly others can go further with additional CDNs.

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 23, 2018

Member

@Eilon Those are CDNs that just auto-host everything on NPM, so we're already there :). I've used UnPkg a few times.

Member

anurse commented Mar 23, 2018

@Eilon Those are CDNs that just auto-host everything on NPM, so we're already there :). I've used UnPkg a few times.

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 23, 2018

Member

@mikaelm12 can you find out what we have to do to host on cdnjs.org and report back with your findings? I'd imagine we need to get approval from them first. @jbagga may have already done some work here with our jQuery Unobtrusive Validation package.

Member

anurse commented Mar 23, 2018

@mikaelm12 can you find out what we have to do to host on cdnjs.org and report back with your findings? I'd imagine we need to get approval from them first. @jbagga may have already done some work here with our jQuery Unobtrusive Validation package.

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Mar 23, 2018

Member

(Of course, this is at a lower priority level than issues that involve code changes, but when you have downtime, etc. ;))

Member

anurse commented Mar 23, 2018

(Of course, this is at a lower priority level than issues that involve code changes, but when you have downtime, etc. ;))

@jbagga

This comment has been minimized.

Show comment
Hide comment
@jbagga

jbagga Mar 23, 2018

You have to open an issue with cdnjs with a request to host your package and then send a PR to add it there cdnjs/cdnjs#7176

jbagga commented Mar 23, 2018

You have to open an issue with cdnjs with a request to host your package and then send a PR to add it there cdnjs/cdnjs#7176

@Eilon

This comment has been minimized.

Show comment
Hide comment
@Eilon

Eilon Apr 10, 2018

Member

@muratg / @anurse / @mikaelm12 - any action today for this?

Member

Eilon commented Apr 10, 2018

@muratg / @anurse / @mikaelm12 - any action today for this?

@mikaelm12

This comment has been minimized.

Show comment
Hide comment
@mikaelm12

mikaelm12 Apr 10, 2018

Contributor

Starting the process cdnjs/cdnjs#12694

Contributor

mikaelm12 commented Apr 10, 2018

Starting the process cdnjs/cdnjs#12694

@anurse anurse modified the milestones: 2.1.0-rc1, 2.1.0 Apr 23, 2018

@anurse anurse modified the milestones: 2.1.0, 2.2.0-mq May 25, 2018

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Jun 8, 2018

Member

@davidfowl you mentioned that libman is going to support unpkg, so is this still relevant? If not, we should withdraw the request with cdnjs.

Member

anurse commented Jun 8, 2018

@davidfowl you mentioned that libman is going to support unpkg, so is this still relevant? If not, we should withdraw the request with cdnjs.

@muratg muratg removed the SHP: Approved label Jun 8, 2018

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Jun 11, 2018

Member

Even if we don't need it for LibMan, we've got a couple customers asking about it. I think we should just get this done.

Member

anurse commented Jun 11, 2018

Even if we don't need it for LibMan, we've got a couple customers asking about it. I think we should just get this done.

@davidfowl

This comment has been minimized.

Show comment
Hide comment
@davidfowl

davidfowl Jun 11, 2018

Member

Are we going to do it every release? If no then we shouldn’t bother

Member

davidfowl commented Jun 11, 2018

Are we going to do it every release? If no then we shouldn’t bother

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Jun 11, 2018

Member

Once you add it to CDNjs they automatically update from your NPM module. But if we ever restructure our module we'd have to update that. So meh, maybe we'll just leave it out and wait and see what customers want :). Unpkg is fine for now.

Member

anurse commented Jun 11, 2018

Once you add it to CDNjs they automatically update from your NPM module. But if we ever restructure our module we'd have to update that. So meh, maybe we'll just leave it out and wait and see what customers want :). Unpkg is fine for now.

@anurse anurse closed this Jun 11, 2018

@anurse

This comment has been minimized.

Show comment
Hide comment
@anurse

anurse Jun 11, 2018

Member

@mikaelm12 can you close the issue on CDNjs, I don't have the power ;)

Member

anurse commented Jun 11, 2018

@mikaelm12 can you close the issue on CDNjs, I don't have the power ;)

@anurse anurse reopened this Jun 11, 2018

@anurse anurse modified the milestones: 2.2.0-mq, 2.2.0 Jun 11, 2018

@mikaelm12

This comment has been minimized.

Show comment
Hide comment
@mikaelm12

mikaelm12 Jun 11, 2018

Contributor

cdnjs/cdnjs#12694 Closed (For now)

Contributor

mikaelm12 commented Jun 11, 2018

cdnjs/cdnjs#12694 Closed (For now)

@mikaelm12 mikaelm12 closed this Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment