This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Java Client API review cleanup #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
approved these changes
Sep 13, 2018
| } | ||
|
|
||
| public static PingMessage getInstance() { | ||
| if (instance == null) { |
There was a problem hiding this comment.
This doesn't need to be lazy-initialized
There was a problem hiding this comment.
Yeah, skip the lazy-init and just initialize it in the field.
analogrelay
approved these changes
Sep 13, 2018
| } | ||
|
|
||
| public static PingMessage getInstance() { | ||
| if (instance == null) { |
There was a problem hiding this comment.
Yeah, skip the lazy-init and just initialize it in the field.
davidfowl
reviewed
Sep 15, 2018
| { | ||
| } | ||
|
|
||
| public static PingMessage getInstance() {return instance;} |
There was a problem hiding this comment.
Do we always want a new line after a bracket? I'll add a spotless rule
There was a problem hiding this comment.
I think it's more about the spaces here
There was a problem hiding this comment.
Yeah I get that, but it's easier to normalize and write rules for if we just put newlines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitting a couple of things from the API review here. Part of #2957