Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

fix : DefaultFilesMiddleware serve with unicode path #257

Merged
merged 2 commits into from Oct 17, 2018
Merged

fix : DefaultFilesMiddleware serve with unicode path #257

merged 2 commits into from Oct 17, 2018

Conversation

newbienewbie
Copy link
Contributor

  • check path by PathString.Value
  • add test

address #3633

@newbienewbie
fix : DefaultFilesMiddleware unicode path
12ad335 
- check path by PathString.Value
- add test

address #3633
@dnfclas
Copy link

dnfclas commented Oct 17, 2018 •
edited

CLA assistant check
All CLA requirements met.

poke
poke reviewed Oct 17, 2018
View reviewed changes
Copy link

@poke poke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please run the code formatter in the test file? There are a few minor nits that should get fixed that way.

Btw. you don’t need to create a new pull request; you can just commit and push to your branch to update the PR.

@poke poke mentioned this pull request Oct 17, 2018
Closed
@newbienewbie
formatting
3c3cb28 
format the file of `DefaultFilesMiddlewares.cs`
@newbienewbie
Copy link
Contributor Author

@poke Sorry for the inconvenience . I didn't realize I should format the code.

@Tratcher Tratcher self-assigned this Oct 17, 2018
@Tratcher Tratcher added this to the 2.2.0 milestone Oct 17, 2018
@Tratcher Tratcher merged commit a435872 into aspnet:release/2.2 Oct 17, 2018
@Tratcher
Copy link
Member

Thank you.

@Tratcher Tratcher mentioned this pull request Oct 17, 2018
Closed
@newbienewbie
Copy link
Contributor Author

@Tratcher I would like to thank you too for giving me a chance to participate in the development :)

@newbienewbie newbienewbie deleted the unicode-path-defaultfiles branch October 17, 2018 15:11
@Tratcher Tratcher mentioned this pull request Oct 24, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@poke poke poke left review comments

@Tratcher Tratcher Tratcher approved these changes

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@newbienewbie @dnfclas @Tratcher @poke