New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet-core-2.1.md #1073

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@federicorinaldi
Contributor

federicorinaldi commented May 31, 2018

Visual Studio 2017 15.7 has been released now so this document is outdated

Update dotnet-core-2.1.md
Visual Studio 2017 15.7 has been released now so this document is outdated
@AngelosP

This comment has been minimized.

Contributor

AngelosP commented Jun 1, 2018

Thank you for the heads up. I'm not 100% sure why we think it's outdated, can you please give me a hint? Don't forget that even though VS 15.7 is out, that doesn't mean 100% of our customers have moved over to it. If a customer is still using VS15.5 or VS15.6 we want them to be able to read this .md file and understand that they should upgrade to VS15.7 or later.

@federicorinaldi

This comment has been minimized.

Contributor

federicorinaldi commented Jun 1, 2018

Exactly! If you look at the PR, you can see that I only updated the section for VS 15.7 the rest (for VS 15.6 and 15.5) are still there. The change I've made is basically to allow the people to upgrade to VS 15.7 or later without pointing them to the Preview page for download

@AngelosP

This comment has been minimized.

Contributor

AngelosP commented Jun 1, 2018

I'm really sorry, I almost never use GitHub PRs and I just didn't read it right :(

@AngelosP AngelosP merged commit 68c9db4 into aspnet:master Jun 1, 2018

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment