IsOnAir reload issue #43 #45
Conversation
|
Hi @matsprea, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@matsprea, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Thanks for this. I think this would work even better if it detected the following state changes and reloaded for each one:
I don't want it to auto-reload for the on-air to off-air state change as people might have paused it and it would be annoying if it flipped back automatically. You'll probably need to update the new action you added to return a state (rather than boolean) and track the state change in the client, reloading when the changes above are detected. |
| var interval = window.setInterval(function () { | ||
| var now = new Date(), | ||
| diff = dateDiff(now, futureDate); | ||
|
|
||
| if (!isOnAirPolling && diff.totalSecs < 3 * 60) { | ||
| isOnAirPolling = window.setInterval(function() { | ||
|
|
There was a problem hiding this comment.
Please use spaces (4) instead of tabs.
|
I will update the PR to detect the state changes, but to do so the polling could not be limited to the last few minutes before the OnAir as it does in this PR. |
|
Now, it should do what are you're suggeting, but only if there is a next show scheduled. |
| get | ||
| { | ||
| if (!string.IsNullOrEmpty(AdminMessage)) | ||
| return ShowStatus.Standby; |
|
⌚ |
… and when it's in "Standby".
|
The polling is active only in the last N minutes of the countdown or when it's in standby. |
|
@DamianEdwards should I try to update the PR for addressing the conflicts or there is no longer interest in this feature? |
|
@martinpf If I'm not wrong, the current website update itself and show's the youtube popup when the status "OnAir" |
|
@matsprea I have no plan to add this right now, but thanks. |
In the last 3 minutes of the countdown it checks if the show is OnAir and if os it reloads the page.