New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues in vue template #362

Merged
merged 8 commits into from Dec 7, 2018

Conversation

Projects
None yet
4 participants
@personball
Copy link
Contributor

personball commented Dec 7, 2018

fix some issues in vue template:

  1. Fix css in main.less when build for production
  2. Fix vue.config.js, files should be copy into dist folder when build for production
  3. Fix appconst.ts defaultLocalizationSourceName should be AbpProjectName
  4. Sample code about pagerequest of request a list in user.vue role.vue tenant.vue has a sql injection problem, fix user.vue and add todo for role.vue tenant.vue, also, add console.warn in Util.buildFilters
  5. Replace PagedResultRequest with PagedUserResultRequest in IUserAppService as sample code deal with query filters.
  6. Add rename.ps1 for test

@maliming maliming added this to the v4.3 milestone Dec 7, 2018

@maliming maliming added the enhancement label Dec 7, 2018

@alirizaadiyahsi

This comment has been minimized.

Copy link
Member

alirizaadiyahsi commented Dec 7, 2018

Hi @personball, thanks for contribution. But I can't understand why you added rename.ps1 ? Why we need this?

@personball

This comment has been minimized.

Copy link
Contributor

personball commented Dec 7, 2018

Hi @alirizaadiyahsi, with rename.ps1, we can test if some where in project template missing a placeholder. For example, appconst.ts in vue\src\lib\ , has a defaultLocalizationSourceName "FengCloud" before.

Add rename.ps1 here just for test purpose.
You can remove it as your pleasure.

@alirizaadiyahsi alirizaadiyahsi self-assigned this Dec 7, 2018

@alirizaadiyahsi alirizaadiyahsi merged commit 7ef0644 into aspnetboilerplate:master Dec 7, 2018

@alirizaadiyahsi

This comment has been minimized.

Copy link
Member

alirizaadiyahsi commented Dec 7, 2018

Thanks @personball

@@ -43,7 +43,7 @@
transition: all 3s;
}
.main{
position: absolute;
//position: absolute;

This comment has been minimized.

@ryancyq

ryancyq Dec 8, 2018

Contributor

should we remove this entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment