New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors in vue template when run yarn serve #366

Merged
merged 5 commits into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@personball
Copy link
Contributor

personball commented Dec 11, 2018

Downgrade iview version to 2.13.1, and vue-property-decorator to 6.0.0, can fix errors when run yarn serve in vue template.

_20181211213014

@@ -11,12 +11,12 @@
"abp-web-resources": "^3.8.2",
"axios": "^0.18.0",
"famfamfam-flags": "^1.0.0",
"iview": "^3.0.0",
"iview": "^2.13.1",

This comment has been minimized.

@acjh

acjh Dec 11, 2018

Contributor

~3.0.0 is fine. See #343 (comment).

This comment has been minimized.

@personball

personball Dec 11, 2018

Contributor

Not release yet?

This comment has been minimized.

@acjh

acjh Dec 12, 2018

Contributor

Not changed yet, as I was hoping for a fix in iView.
You can modify your PR to make that change instead.
It's preferable as compared to downgrading a major version.

Remember to update that line in yarn.lock. Thanks!

@personball

This comment has been minimized.

Copy link
Contributor

personball commented Dec 12, 2018

@acjh #343 has merged. I close this pr, and wait for next release.

@personball personball closed this Dec 12, 2018

@personball

This comment has been minimized.

Copy link
Contributor

personball commented Dec 12, 2018

@acjh Wait, you mean just modify one line of iview version ^3.0.0 to ~3.0.0?

@personball personball reopened this Dec 12, 2018

@personball

This comment has been minimized.

Copy link
Contributor

personball commented Dec 12, 2018

@acjh It works, Thanks.
_20181212094047

@ismcagdas ismcagdas added this to the v4.3 milestone Dec 12, 2018

@ismcagdas

This comment has been minimized.

Copy link
Member

ismcagdas commented Dec 17, 2018

@personball is your PR completed ? If so, we will review and merge it.

@personball

This comment has been minimized.

Copy link
Contributor

personball commented Dec 17, 2018

@ismcagdas Yes.

@ismcagdas ismcagdas merged commit 7021604 into aspnetboilerplate:master Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment