clickLink callback doesn't report errors #304

Closed
mullr opened this Issue Mar 27, 2012 · 2 comments

Comments

Projects
None yet
2 participants

mullr commented Mar 27, 2012

In my first day of using zombie (to good effect, I should add), I spent many hours chasing what I thought to be bugs in zombie itself but what turned out to be bugs or regressions in my own code. It happened several times that there was some exception triggered by my tests (a TypeError or something), but zombie kept on running happily without saying anything about it. Of course I could see these exceptions with the debug flag turned on, but it seems less than great to require that.

Concretely:

When using browser.clickLink, there may be javascript code that runs in the page as a result. If any of this code throws an exception, the first element argument to the callback is currently null. By returning some information about the exceptions in this field, then either the client code or a unit testing framework can see that something happened and fail the test. (vows does this)

Owner

assaf commented May 28, 2012

Should be fixed now.

assaf closed this May 28, 2012

mullr commented May 30, 2012

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment