Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Don't override offset* #242

Merged
merged 1 commit into from

2 participants

@JustinTulloss

Offset* works if you leave it alone. It had been overridden at some point and should not have been.

@JustinTulloss JustinTulloss for some reason, all positions and widths were being overridden. they…
… work fine without being overridden, and are pretty much guaranteed to be incorrect if they are overridden. Taking out the override
741fb53
@assaf assaf merged commit 9e8972c into assaf:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 27, 2011
  1. @JustinTulloss

    for some reason, all positions and widths were being overridden. they…

    JustinTulloss authored
    … work fine without being overridden, and are pretty much guaranteed to be incorrect if they are overridden. Taking out the override
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 7 deletions.
  1. +0 −7 lib/zombie/jsdom_patches.coffee
View
7 lib/zombie/jsdom_patches.coffee
@@ -3,13 +3,6 @@ HTML = require("jsdom").dom.level3.html
URL = require("url")
{ raise } = require("./helpers")
-
-HTML.HTMLElement.prototype.__defineGetter__ "offsetLeft", -> 0
-HTML.HTMLElement.prototype.__defineGetter__ "offsetTop", -> 0
-HTML.HTMLElement.prototype.__defineGetter__ "offsetWidth", -> 100
-HTML.HTMLElement.prototype.__defineGetter__ "offsetHeight", -> 100
-
-
# Default behavior for clicking on links: navigate to new URL is specified.
HTML.HTMLAnchorElement.prototype._eventDefaults =
click: (event)->
Something went wrong with that request. Please try again.