Skip to content
This repository has been archived by the owner on Dec 29, 2021. It is now read-only.

Feature/86/run using active compilation profile #97

Conversation

azriel91
Copy link
Contributor

Issue #86

  • I have created tests for any new feature, or added regression tests for bugfixes.
  • cargo test succeeds
  • Clippy is happy: cargo +nightly clippy succeeds
  • Rustfmt is happy: cargo +nightly fmt succeeds

@epage
Copy link
Collaborator

epage commented Mar 27, 2018

Looks good!

Do you mind squashing your commits? If you do so, let me know when you push again because force pushes don't cause notifications to be sent.

@azriel91 azriel91 force-pushed the feature/86/run-using-active-compilation-profile branch from 707417b to 141f59e Compare March 27, 2018 21:07
@azriel91
Copy link
Contributor Author

Hopefully I'm not noob 😄, I assume "squash commits" means squash all of them into 1 commit.

Pushed!

@epage
Copy link
Collaborator

epage commented Mar 27, 2018

Hopefully I'm not noob 😄, I assume "squash commits" means squash all of them into 1 commit.

Yup, thats what I meant. More generally, the desire is to clean up commit history (re-arrange or squash commits as needed) to give us a clean commit history. This especially helpful when someone presents a PR with a clean history but then we iterate on some aspects of it, causing commits that should be cleaned up.

I was just being more specific in your case because all you needed was to squash :)

@epage epage merged commit d3daabb into assert-rs:master Mar 27, 2018
@azriel91 azriel91 deleted the feature/86/run-using-active-compilation-profile branch March 27, 2018 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants