Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change with_stdin to &mut to fix #22 #23

Merged
merged 2 commits into from
Jul 13, 2018
Merged

Change with_stdin to &mut to fix #22 #23

merged 2 commits into from
Jul 13, 2018

Conversation

mssun
Copy link
Contributor

@mssun mssun commented Jul 13, 2018

This is a quick fix. I didn't carefully read the code. Please review before merge. Thanks.

Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to post my PR :)

@@ -24,13 +24,13 @@ pub trait CommandStdInExt {
/// .with_stdin("42")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify this example so we have verification for your use case?

@epage
Copy link
Contributor

epage commented Jul 13, 2018

Eh, CI is close enough

@epage epage merged commit 074b63a into assert-rs:master Jul 13, 2018
epage added a commit to epage/assert_cmd that referenced this pull request Sep 27, 2024
…go-deny-action-2.x

chore(deps): Update EmbarkStudios/cargo-deny-action action to v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants