Fix white ambient in STL loader #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A problem that sneaked in from #1293 (f84851e) due to insufficient code review, later reported in #2059 but not fixed properly. Having a white ambient practically means all other color information is ignored and the model stays bright white no matter how you set up your lighting, so putting it back to how it was before the commit above.
|
OK, merged. Now the old behavious shall be there again. Thanks a lt for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A problem that sneaked in from #1293 (f84851e) due to insufficient code review, later reported in #2059 but never fixed properly. Having a white ambient practically means all other color information is ignored and the model stays bright white no matter how you set up your lighting. Application code then has to check for this case and patch it during model import (see here, for example). Putting it back to how it was before the commit above so workarounds on app-side can be removed again.
Thanks for merging.