Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white ambient in STL loader #2563

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@mosra
Copy link
Contributor

commented Jul 25, 2019

A problem that sneaked in from #1293 (f84851e) due to insufficient code review, later reported in #2059 but never fixed properly. Having a white ambient practically means all other color information is ignored and the model stays bright white no matter how you set up your lighting. Application code then has to check for this case and patch it during model import (see here, for example). Putting it back to how it was before the commit above so workarounds on app-side can be removed again.

Thanks for merging.

Fix white ambient in STL loader.
A problem that sneaked in from #1293 (f84851e) 
due to insufficient code review, later reported in #2059 but not fixed 
properly. Having a white ambient practically means all other color information 
is ignored and the model stays bright white no matter how you set up your 
lighting, so putting it back to how it was before the commit above.

@kimkulling kimkulling merged commit 1c3e934 into assimp:master Jul 30, 2019

6 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kimkulling

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

OK, merged. Now the old behavious shall be there again. Thanks a lt for the contribution.

@simonschmeisser simonschmeisser referenced this pull request Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.