Test Exporter Descriptions and IDs #2566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"json" is a very vague exporter ID, change to "assjson" Add a unit test to ensure all exporter have unique IDs and that they all have an ID, description and extension
EXPECT_* triggers sign compare error with literal 0 and unsigned Use 0u literal with size_t
|
Good catch, I was unsure if I shall use assjson or just json. So I started with json. Makes sense to swithc to assimpjson from my point of view. |
kimkulling
approved these changes
Jul 26, 2019
Full fix for assimp#2557 These macros should be all-caps. Correct the cmakelists
|
Just realised that this reverted panquez' fix for issue #2557 |
Add exporter detail.
|
Merged, thanks a lot for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test to ensure all registered Exporters have a description that makes sense
Also changes the Exporter ID of Assimp JSON format from "json" to "assjson", as json is a rather common extension that is almost certainly going to be used by something else.