Fix validation issues on us phone number #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for the pull request. |
Contributor
Author
|
This one really is a one line no-brainer, but without this pulled the phone number cannot validate for me at all (when the phone number is just a number) which makes the entire module useless. I wonder how it stayed in so long? ;) If you insist I will go it a go, but it will be some time before I can find time to do it. |
Owner
|
Only a test case can prevent this feature to be accidentally removed in the future and break your code. |
Model value is added as a number which ensures it can validate (which is what this PR is for). I noticed other tests are adding the phone number as a string (in br-phone.test.js), which probably defeats the test.
Contributor
Author
|
@assisrafael I finally had time to get back around to do the test you asked for. Hoping to see this merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple, but makes the directive useful for me.