Fixes bug watching min and max attributes on money mask #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs when these attributes are changed dynamically .
Owner
|
Thank you for the pull request. Can you write a test case that exhibits this bug? |
Author
|
I wasn't able to simulate this bug in tests :/ Can I simulate it in Fiddle then? |
Owner
|
It is a start. |
|
👍 and ➕ 1 for this pull request. I can confirm that it fixes the bug that I've been experiencing as well. |
Owner
|
This PR will not be merged because the intended behavior is to use an expression not an interpolation: https://stackoverflow.com/questions/14876112/angularjs-difference-between-the-observe-and-watch-methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugs occurs when these attributes are changed dynamically .