Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Improve API's documentation #682

Closed
HerringtonDarkholme opened this issue Oct 27, 2023 · 2 comments
Closed

[doc] Improve API's documentation #682

HerringtonDarkholme opened this issue Oct 27, 2023 · 2 comments

Comments

@HerringtonDarkholme
Copy link
Member

Napi doc now only lists methods and assume users have experience or mindsets about programmatic usage.

This is not universally true. To better guide users, the doc site should be rewritten into

  • why
  • guide
  • examples
  • caveats

Python should also have similar docs.

@HerringtonDarkholme HerringtonDarkholme changed the title [doc] Improve NAPI's documentation [doc] Improve API's documentation Oct 27, 2023
@gkapfham
Copy link

gkapfham commented Nov 7, 2023

Hello @HerringtonDarkholme, I checked the public-facing documentation for a description of the Python API and I could not yet find it. If you can point me in the direction of this documentation and give me some suggestions for testing that you would like me to complete, I would be glad to try out the Python bindings and provide feedback. Thanks!

@HerringtonDarkholme
Copy link
Member Author

Hi @gkapfham, sg-team has not yet enough time to prepare the Python API doc.

However, you can look at the test case https://github.com/ast-grep/ast-grep/tree/main/crates/pyo3/tests
to know the usage of Python API.

There is also a type declaration file for Python, which will be useful as well.
https://github.com/ast-grep/ast-grep/blob/main/crates/pyo3/ast_grep_py/ast_grep_py.pyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants