Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaces CSSS framework support with support for Inspire.js #197

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@DuaneOBrien
Copy link
Contributor

commented Oct 6, 2019

Fixes #196

  • renames CSSS to Inspire.js in the README and updates the corresponding URLs
  • renames the plugins/csss.js to plugins/inspire.js, updates the isActive test and related object names
  • deletes csss-sample.slideshow.pdf
  • adds inspire-sample-slideshow.pdf
@DuaneOBrien

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2019

Note: The inspire-sample-slideshow.pdf file was generated using

node decktape.js --slides 1-26 https://inspirejs.org docs/examples/inspirejs-sample-slideshow.pdf

decktape is throwing a Page error: DOMException between slides 26-28, I suspect because of the Annotated Videos slide in the source: https://github.com/LeaVerou/inspire.js/blob/master/index.html

It's unclear to me if this is an existing bug or one that is surfaced in the new framework.

@astefanutti astefanutti merged commit 5fb1c07 into astefanutti:master Oct 7, 2019
@astefanutti

This comment has been minimized.

Copy link
Owner

commented Oct 7, 2019

Awesome. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.