func_scramble: Fix null pointer dereference.

InterLinked1 · Friendly Automation · commit c6ca266acdb3 · 2022-09-22T10:23:21.000-05:00
Fix segfault due to null pointer dereference
inside the audiohook callback.

ASTERISK-30220 #close

Change-Id: Ideb80f606974366e89d619d908744230b5a5a259
diff --git a/funcs/func_scramble.c b/funcs/func_scramble.c
@@ -125,6 +125,7 @@ static int scramble_callback(struct ast_audiohook *audiohook, struct ast_channel
 	}
 
 	if (frame->frametype == AST_FRAME_VOICE) { /* only invert voice frequencies */
+		ni = datastore->data;
 		/* Based on direction of frame, and confirm it is applicable */
 		if (!(direction == AST_AUDIOHOOK_DIRECTION_READ ? ni->rx : ni->tx)) {
 			return 0;

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ static int scramble_callback(struct ast_audiohook *audiohook, struct ast_channel`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`if (frame->frametype == AST_FRAME_VOICE) { /* only invert voice frequencies */`
	`128`	`+ ni = datastore->data;`
`128`	`129`	`/* Based on direction of frame, and confirm it is applicable */`
`129`	`130`	`if (!(direction == AST_AUDIOHOOK_DIRECTION_READ ? ni->rx : ni->tx)) {`
`130`	`131`	`return 0;`