res_calendar_icalendar: Print iCalendar error on parsing failure.

InterLinked1 · asterisk-org-access-app[bot] · commit f4845f756f27 · 2024-01-23T18:18:56.000Z
If libical fails to parse a calendar, print the error message it provdes. Resolves: #492
diff --git a/res/res_calendar_icalendar.c b/res/res_calendar_icalendar.c
@@ -155,6 +155,10 @@ static icalcomponent *fetch_icalendar(struct icalendar_pvt *pvt)
 
 	if (!ast_strlen_zero(ast_str_buffer(response))) {
 		comp = icalparser_parse_string(ast_str_buffer(response));
+		if (!comp) {
+			ast_debug(3, "iCalendar response data: %s\n", ast_str_buffer(response));
+			ast_log(LOG_WARNING, "Failed to parse iCalendar data: %s\n", icalerror_perror());
+		}
 	}
 	ast_free(response);
 

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,10 @@ static icalcomponent fetch_icalendar(struct icalendar_pvt pvt)`
`155`	`155`
`156`	`156`	`if (!ast_strlen_zero(ast_str_buffer(response))) {`
`157`	`157`	`comp = icalparser_parse_string(ast_str_buffer(response));`
	`158`	`+ if (!comp) {`
	`159`	`+ ast_debug(3, "iCalendar response data: %s\n", ast_str_buffer(response));`
	`160`	`+ ast_log(LOG_WARNING, "Failed to parse iCalendar data: %s\n", icalerror_perror());`
	`161`	`+ }`
`158`	`162`	`}`
`159`	`163`	`ast_free(response);`
`160`	`164`