Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-feature]: chan_dahdi: Allow fake ringing to be inhibited when immediate=yes #118

Closed
InterLinked1 opened this issue May 25, 2023 · 0 comments · Fixed by #119
Closed

[new-feature]: chan_dahdi: Allow fake ringing to be inhibited when immediate=yes #118

InterLinked1 opened this issue May 25, 2023 · 0 comments · Fixed by #119
Assignees
@InterLinked1
Labels
new-feature support-level-core Functionality with core support level

Comments

@InterLinked1
Copy link
Contributor

Feature Description

Imported from JIRA: https://issues.asterisk.org/jira/browse/ASTERISK-30003

Currently, if an FXS port is configured with immediate=yes, then a fake ringback tone is immediately applied on the channel before dialplan execution begins and continues until the dialplan stops it.

This is highly undesirable because even if the channel starts doing something else immediately, the audible ring is noticeable and distracting. Additionally, this behavior is just downright incorrect and should never have existed in the first place.

This adds an immediate_ring config option to chan_dahdi that allows this fake ringback tone to be suppressed if it is not wanted, leaving the default behavior unchanged.
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue May 25, 2023
@InterLinked1
sig_analog: Allow immediate fake ring to be suppressed.
01125c8 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

Resolves: asterisk#118
ASTERISK-30003

UserNote: The immediatering option can now be set to no
to suppress the fake audible ringback provided
when immediate=yes on FXS channels.
@InterLinked1 InterLinked1 mentioned this issue May 25, 2023
Merged
@jcolp jcolp added support-level-core Functionality with core support level and removed triage labels May 25, 2023
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue Jun 8, 2023
@InterLinked1
sig_analog: Allow immediate fake ring to be suppressed.
7cc2238 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

ASTERISK-30003 #close
Resolves: asterisk#118

UserNote: The immediatering option can now be set to no to suppress
the fake audible ringback provided when immediate=yes on FXS channels.
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@InterLinked1
sig_analog: Allow immediate fake ring to be suppressed.
d87abb2 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

ASTERISK-30003 #close
Resolves: #118

UserNote: The immediatering option can now be set to no to suppress
the fake audible ringback provided when immediate=yes on FXS channels.
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@InterLinked1
sig_analog: Allow immediate fake ring to be suppressed.
0d1ddb1 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

ASTERISK-30003 #close
Resolves: #118

UserNote: The immediatering option can now be set to no to suppress
the fake audible ringback provided when immediate=yes on FXS channels.
asterisk-org-access-app bot pushed a commit that referenced this issue Jul 10, 2023
@InterLinked1 @asterisk-org-access-app
sig_analog: Allow immediate fake ring to be suppressed.
8cd7548 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

ASTERISK-30003 #close
Resolves: #118

UserNote: The immediatering option can now be set to no to suppress
the fake audible ringback provided when immediate=yes on FXS channels.
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
@InterLinked1 @asteriskteam
sig_analog: Allow immediate fake ring to be suppressed.
69f5aed 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

ASTERISK-30003 #close
Resolves: #118

UserNote: The immediatering option can now be set to no to suppress
the fake audible ringback provided when immediate=yes on FXS channels.

(cherry picked from commit 0d1ddb1)
asterisk-org-access-app bot pushed a commit that referenced this issue Sep 6, 2023
@InterLinked1 @asteriskteam
sig_analog: Allow immediate fake ring to be suppressed.
967e8f6 
When immediate=yes on an FXS channel, sig_analog will
start fake audible ringback that continues until the
channel is answered. Even if it answers immediately,
the ringback is still audible for a brief moment.
This can be disruptive and unwanted behavior.

This adds an option to disable this behavior, though
the default behavior remains unchanged.

ASTERISK-30003 #close
Resolves: #118

UserNote: The immediatering option can now be set to no to suppress
the fake audible ringback provided when immediate=yes on FXS channels.

(cherry picked from commit d87abb2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InterLinked1 InterLinked1

Labels
new-feature support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sig_analog: Allow immediate fake ring to be suppressed. InterLinked1/asterisk
2 participants
@jcolp @InterLinked1