Skip to content

[bug]: manager: UpdateConfig triggers reload with "Reload: no" #551

Description

@InterLinked1

Severity

Minor

Versions

Git

Components/Modules

manager.c

Operating Environment

N/A

Frequency of Occurrence

Constant

Issue Description

If the Reload header is provided, a reload will always occur, even if Reload: no. The documentation says that this should not happen, but the code is a little bit sloppy. This patch makes the header work as described in the documentation.

Relevant log output

root@testdebian:/usr/local/src/cami# ./amicli -utest
*** Successfully logged in to AMI on 127.0.0.1 (test) ***
(Callback) Event Received: FullyBooted
(Callback) Event Received: SuccessfulAuth
Action: UpdateConfig
reload: no
srcfilename: /etc/asterisk/test.conf
dstfilename: /etc/asterisk/test.conf
PreserveEffectiveContext
...


******* RESPONSE *******
ActionID: 2 (Success) => # Events: 1
*** Event => # Fields: 2
Response        : Success
ActionID        : 2
(Callback) Event Received: Reload

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions