Skip to content

[improvement]: Enhance and add additional PJSIP pubsub callbacks #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
InterLinked1 opened this issue May 11, 2023 · 0 comments · Fixed by #82
Closed

[improvement]: Enhance and add additional PJSIP pubsub callbacks #81

InterLinked1 opened this issue May 11, 2023 · 0 comments · Fixed by #82
Assignees
@InterLinked1
Labels
improvement support-level-core Functionality with core support level

Comments

@InterLinked1
Copy link
Contributor

Improvement Description

This adds several master-only APIs to res_pjsip_pubsub that are necessary for future features that rely on functionality not currently supported by res_pjsip_pubsub.

Imported from: https://issues.asterisk.org/jira/browse/ASTERISK-30485
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue May 11, 2023
@InterLinked1
res_pjsip_pubsub: Add new pubsub module capabilities.
473bfe0 
The existing res_pjsip_pubsub APIs are somewhat limited in
what they can do. This adds a few API extensions that make
it possible for PJSIP pubsub modules to implement richer
features than is currently possible.

* Allow pubsub modules to get a handle to pjsip_rx_data on subscription
* Allow pubsub modules to run a callback when a subscription is renewed
* Allow pubsub modules to run a callback for outgoing NOTIFYs, with
  a handle to the tdata, so that modules can append their own headers
  to the NOTIFYs

This change does not add any features directly, but makes possible
several new features that will be added in future changes.

Resolves: asterisk#81
ASTERISK-30485 #close

Master-Only: True
@InterLinked1 InterLinked1 mentioned this issue May 11, 2023
Merged
@jcolp jcolp added support-level-core Functionality with core support level and removed triage labels May 11, 2023
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue May 18, 2023
@InterLinked1
res_pjsip_pubsub: Add new pubsub module capabilities.
32b05a7 
The existing res_pjsip_pubsub APIs are somewhat limited in
what they can do. This adds a few API extensions that make
it possible for PJSIP pubsub modules to implement richer
features than is currently possible.

* Allow pubsub modules to get a handle to pjsip_rx_data on subscription
* Allow pubsub modules to run a callback when a subscription is renewed
* Allow pubsub modules to run a callback for outgoing NOTIFYs, with
  a handle to the tdata, so that modules can append their own headers
  to the NOTIFYs

This change does not add any features directly, but makes possible
several new features that will be added in future changes.

Resolves: asterisk#81
ASTERISK-30485 #close

Master-Only: True
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue May 18, 2023
@InterLinked1
res_pjsip_pubsub: Add new pubsub module capabilities.
2d205e8 
The existing res_pjsip_pubsub APIs are somewhat limited in
what they can do. This adds a few API extensions that make
it possible for PJSIP pubsub modules to implement richer
features than is currently possible.

* Allow pubsub modules to get a handle to pjsip_rx_data on subscription
* Allow pubsub modules to run a callback when a subscription is renewed
* Allow pubsub modules to run a callback for outgoing NOTIFYs, with
  a handle to the tdata, so that modules can append their own headers
  to the NOTIFYs

This change does not add any features directly, but makes possible
several new features that will be added in future changes.

Resolves: asterisk#81
ASTERISK-30485 #close

Master-Only: True
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue May 18, 2023
@InterLinked1
res_pjsip_pubsub: Add new pubsub module capabilities.
98082e1 
The existing res_pjsip_pubsub APIs are somewhat limited in
what they can do. This adds a few API extensions that make
it possible for PJSIP pubsub modules to implement richer
features than is currently possible.

* Allow pubsub modules to get a handle to pjsip_rx_data on subscription
* Allow pubsub modules to run a callback when a subscription is renewed
* Allow pubsub modules to run a callback for outgoing NOTIFYs, with
  a handle to the tdata, so that modules can append their own headers
  to the NOTIFYs

This change does not add any features directly, but makes possible
several new features that will be added in future changes.

Resolves: asterisk#81
ASTERISK-30485 #close

Master-Only: True
InterLinked1 added a commit to InterLinked1/asterisk that referenced this issue May 18, 2023
@InterLinked1
res_pjsip_pubsub: Add new pubsub module capabilities.
75f43d0 
The existing res_pjsip_pubsub APIs are somewhat limited in
what they can do. This adds a few API extensions that make
it possible for PJSIP pubsub modules to implement richer
features than is currently possible.

* Allow pubsub modules to get a handle to pjsip_rx_data on subscription
* Allow pubsub modules to run a callback when a subscription is renewed
* Allow pubsub modules to run a callback for outgoing NOTIFYs, with
  a handle to the tdata, so that modules can append their own headers
  to the NOTIFYs

This change does not add any features directly, but makes possible
several new features that will be added in future changes.

Resolves: asterisk#81
ASTERISK-30485 #close

Master-Only: True
gtjoseph pushed a commit that referenced this issue May 18, 2023
@InterLinked1
res_pjsip_pubsub: Add new pubsub module capabilities. (#82)
659f2aa 
The existing res_pjsip_pubsub APIs are somewhat limited in
what they can do. This adds a few API extensions that make
it possible for PJSIP pubsub modules to implement richer
features than is currently possible.

* Allow pubsub modules to get a handle to pjsip_rx_data on subscription
* Allow pubsub modules to run a callback when a subscription is renewed
* Allow pubsub modules to run a callback for outgoing NOTIFYs, with
  a handle to the tdata, so that modules can append their own headers
  to the NOTIFYs

This change does not add any features directly, but makes possible
several new features that will be added in future changes.

Resolves: #81
ASTERISK-30485 #close

Master-Only: True
@InterLinked1 InterLinked1 mentioned this issue May 28, 2023
Open
@gibbz00 gibbz00 mentioned this issue Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InterLinked1 InterLinked1

Labels
improvement support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

res_pjsip_pubsub: Add new pubsub module capabilities. InterLinked1/asterisk
2 participants
@jcolp @InterLinked1