Skip to content

users.conf: Deprecate users.conf configuration. #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

InterLinked1
Copy link
Contributor

This deprecates the users.conf config file, which
is no longer as widely supported but still integrated with a number of different modules.

Because there is no real mechanism for marking a
configuration file as "deprecated", and users.conf is not just used in a single place, this now emits a warning to the user when the PBX loads to notify about the deprecation.

This configuration mechanism has been widely criticized and discouraged since its inception, and is no longer relevant to the configuration that most users are doing today. Removing it will allow for some simplification and cleanup in the codebase.

Resolves: #183

UpgradeNote: The users.conf config is now deprecated and will be removed in a future version of Asterisk.

@InterLinked1
Copy link
Contributor Author

No cherry picks required

@asterisk-org-access-app asterisk-org-access-app bot requested a review from a team June 30, 2023 10:26
@asterisk-org-access-app
Copy link

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment stating "No cherry-picks required" so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add "No cherry-picks required".

@seanbright
Copy link
Contributor

seanbright commented Jun 30, 2023

While not technically a module deprecation this will need to be discussed on the asterisk-dev list.

Edit: I will say here that I am against the deprecation and removal of this as I (and others) use this extensively. I'm willing to take over the maintenance of it to keep it in the tree.

This deprecates the users.conf config file, which
is no longer as widely supported but still integrated
with a number of different modules.

Because there is no real mechanism for marking a
configuration file as "deprecated", and users.conf
is not just used in a single place, this now emits
a warning to the user when the PBX loads to notify
about the deprecation.

This configuration mechanism has been widely criticized
and discouraged since its inception, and is no longer
relevant to the configuration that most users are doing
today. Removing it will allow for some simplification
and cleanup in the codebase.

Resolves: asterisk#183

UpgradeNote: The users.conf config is now deprecated
and will be removed in a future version of Asterisk.
@github-actions
Copy link

Successfully merged to branch master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[deprecation]: Deprecate users.conf
4 participants