Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

res_pjsip_logger: Preserve logging state on reloads. #247

Merged

Conversation

InterLinked1
Copy link
Contributor

Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close
Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19575

Resolves: #246

UserNote: Issuing "pjsip reload" will no longer disable logging if it was previously enabled from the CLI.

@InterLinked1
Copy link
Contributor Author

cherry-pick-to: 18
cherry-pick-to: 20
cherry-pick-to: 21

res/res_pjsip_logger.c Outdated Show resolved Hide resolved
res/res_pjsip_logger.c Show resolved Hide resolved
@asteriskteam
Copy link
Contributor

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

res/res_pjsip_logger.c Show resolved Hide resolved
Copy link
Member

@gtjoseph gtjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a coredump during the unit tests and there were more than usual failures in the testsuite. Can you rebase this change on current master and re-push?

Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".

To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.

ASTERISK-29912 #close

Resolves: asterisk#246

UserNote: Issuing "pjsip reload" will no longer disable
logging if it was previously enabled from the CLI.
@gtjoseph gtjoseph dismissed mbradeen’s stale review April 30, 2024 14:50

Because he forgot to.

@gtjoseph gtjoseph added the cherry-pick-test Trigger dry run of cherry-picks label Apr 30, 2024
@github-actions github-actions bot added cherry-pick-testing-in-progress Cherry-Pick tests in progress cherry-pick-checks-passed Cherry-Pick checks passed and removed cherry-pick-test Trigger dry run of cherry-picks labels Apr 30, 2024
@github-actions github-actions bot added cherry-pick-gates-failed Cherry-Pick gates failed and removed cherry-pick-testing-in-progress Cherry-Pick tests in progress labels Apr 30, 2024
@asterisk-org-access-app asterisk-org-access-app bot merged commit 077962d into asterisk:master May 1, 2024
60 of 62 checks passed
Copy link

github-actions bot commented May 1, 2024

Successfully merged to branch master and cherry-picked to ["18","20","21"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: res_pjsip_logger: Reload disables logging
5 participants