-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
res_pjsip_logger: Preserve logging state on reloads. #247
res_pjsip_logger: Preserve logging state on reloads. #247
Conversation
cherry-pick-to: 18 |
b15287c
to
1862a36
Compare
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
d1846c2
to
acf5122
Compare
acf5122
to
9e6df16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a coredump during the unit tests and there were more than usual failures in the testsuite. Can you rebase this change on current master and re-push?
Currently, reloading res_pjsip will cause logging to be disabled. This is because logging can also be controlled via the debug option in pjsip.conf and this defaults to "no". To improve this, logging is no longer disabled on reloads if logging had not been previously enabled using the debug option from the config. This ensures that logging enabled from the CLI will persist through a reload. ASTERISK-29912 #close Resolves: asterisk#246 UserNote: Issuing "pjsip reload" will no longer disable logging if it was previously enabled from the CLI.
9e6df16
to
7555b27
Compare
077962d
into
asterisk:master
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".
To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.
ASTERISK-29912 #close
Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19575
Resolves: #246
UserNote: Issuing "pjsip reload" will no longer disable logging if it was previously enabled from the CLI.