Repository navigation
res_pjsip_logger: Preserve logging state on reloads. - #247
Merged
asterisk-org-access-app[bot] merged 1 commit intoMay 1, 2024
Merged
Conversation
Contributor
Author
|
cherry-pick-to: 18 |
github-actions
Bot
added
testing-in-progress
test-checks-passed
test-gates-failed
and removed
testing-in-progress
labels
gtjoseph
force-pushed
the
master
branch
7 times, most recently
from
September 5, 2023 19:35
b15287c to
1862a36
Compare
jcolp
requested changes
Nov 2, 2023
Contributor
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
InterLinked1
force-pushed
the
master-issue-246
branch
from
March 21, 2024 20:15
d1846c2 to
acf5122
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
stale
test-checks-passed
test-gates-failed
labels
github-actions
Bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
mbradeen
previously requested changes
Mar 21, 2024
InterLinked1
force-pushed
the
master-issue-246
branch
from
April 1, 2024 21:49
acf5122 to
9e6df16
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
gtjoseph
requested changes
Apr 3, 2024
gtjoseph
left a comment
gtjoseph
left a comment
Member
There was a problem hiding this comment.
There was a coredump during the unit tests and there were more than usual failures in the testsuite. Can you rebase this change on current master and re-push?
Currently, reloading res_pjsip will cause logging to be disabled. This is because logging can also be controlled via the debug option in pjsip.conf and this defaults to "no". To improve this, logging is no longer disabled on reloads if logging had not been previously enabled using the debug option from the config. This ensures that logging enabled from the CLI will persist through a reload. ASTERISK-29912 #close Resolves: asterisk#246 UserNote: Issuing "pjsip reload" will no longer disable logging if it was previously enabled from the CLI.
InterLinked1
force-pushed
the
master-issue-246
branch
from
April 4, 2024 17:09
9e6df16 to
7555b27
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
github-actions
Bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
gtjoseph
approved these changes
Apr 30, 2024
jcolp
approved these changes
Apr 30, 2024
github-actions
Bot
added
cherry-pick-testing-in-progress
mbradeen
approved these changes
Apr 30, 2024
github-actions
Bot
added
cherry-pick-gates-failed
github-actions
Bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, reloading res_pjsip will cause logging
to be disabled. This is because logging can also
be controlled via the debug option in pjsip.conf
and this defaults to "no".
To improve this, logging is no longer disabled on
reloads if logging had not been previously
enabled using the debug option from the config.
This ensures that logging enabled from the CLI
will persist through a reload.
ASTERISK-29912 #close
Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19575
Resolves: #246
UserNote: Issuing "pjsip reload" will no longer disable logging if it was previously enabled from the CLI.