sig_analog: Add Call Waiting Deluxe support.#272
Conversation
|
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment with If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add The currently active branches are now 18, 20, 21 and master. |
|
cherry-pick-to: 20 |
github-actions
Bot
added
test-checks-passed
test-gates-passed
and removed
testing-in-progress
labels
gtjoseph
force-pushed
the
master
branch
7 times, most recently
from
b15287c to
1862a36
Compare
|
@asteriskteam Would someone mind giving this review in particular a look soon, if they have time? Don't want to nag, but because of the monolithic architecture of chan_dahdi, it's very difficult to do concurrent development for chan_dahdi so things have to be serialized. Thanks! |
The reality is that community members have no interest in reviewing these kind of changes, and personally I put such changes at the bottom of my todo list. You can continue to do development of chan_dahdi for your needs/interests/purposes, but the review times here are likely to continue to be a long time. |
InterLinked1
force-pushed
the
master-issue-271
branch
from
151752e to
eff6899
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
test-checks-passed
test-gates-passed
pr-submit-testing-in-progress
labels
InterLinked1
force-pushed
the
master-issue-271
branch
from
eff6899 to
1dc0398
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
InterLinked1
force-pushed
the
master-issue-271
branch
from
1dc0398 to
ada13bd
Compare
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
|
This PR has been closed because it has been in "Changes Requested" or "submitter-action-required" state for more than 42 days. |
|
@jcolp Would you mind reopening this? Thanks! |
|
Request completed. |
|
@gtjoseph Is there any way to do a "recheck" on this? I'm not sure what this error is about but it's definitely irrelevant to the change. Thanks! |
@InterLinked1 Well, I wouldn't say "definitely". :) The PR is based on a very old version of the "master" branch that doesn't have commit 64597bf which fixes the quoting of the 100rel column in contrib/ast-db-manage/config/versions/539f68bede2c_add_peer_supported_to_100rel.py. If you rebase the PR on current master and force-push, the alembic issue should go away. |
Yeah, if it hadn't been for the new commit after the GitHub migration, the commit would be from 2022 :)
Okay, just gave that a try, hopefully that fixes it. Surprisingly, it rebased without any issues. |
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
|
@jcolp Seems GitHub thinks changes are requested from your last input on this, would you mind giving this another review when you have a moment? Thanks! |
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
@asteriskteam I have made the requested changes, could you please change the status of this? Thank you. |
|
@jcolp Any chance you'll be able to take another look at this soon? Everything should be good to go now, but the UI still says it's pending a review from you. |
|
Other reviews are higher on my list, so no idea. |
I realize there's no SLA for reviews, but this patch is for a core supported module, and dates back to 2022, making it by far the oldest patch in the review queue. You also additionally asked for a community review - something seldom if ever required for other patches - which in any case was obtained half a year ago now. In light of that, I would at least hope its priority could be reconsidered. |
|
I don't think I ever asked specifically for a community review? It was for someone else, it could have been someone Sangoma too. Reviews generally should have two reviews at a minimum. |
gtjoseph
left a comment
gtjoseph
left a comment
There was a problem hiding this comment.
Can you rebase on current master and force-push? The manager checks are infinitely looping because your base branch doesn't have the updateconfig fixes you did a short time ago.
|
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
Documentation: |
|
Workflow PRCheck completed successfully |
Adds support for Call Waiting Deluxe options to enhance the current call waiting feature. As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function. ASTERISK-30373 #close Resolves: asterisk#271 UserNote: Call Waiting Deluxe can now be enabled for FXS channels by enabling its corresponding option.
The "Imported from Gerrit" line is only in the PR description, I don't think that's needed/useful in the commit message. |
|
Workflow PRCheck completed successfully |
|
This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed. |
|
Workflow PRCPCheck completed successfully |
|
Successfully merged to branch master and cherry-picked to ["20","21","22"] |
5 participants
Adds support for Call Waiting Deluxe options to enhance the current call waiting feature.
As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function.
ASTERISK-30373 #close
Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19748
Resolves: #271