-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chan_iax2: Add log message for rejected calls. #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chan_iax2: Add log message for rejected calls. #414
Conversation
“Possible network issue?” How is this useful? |
REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process. If you don't want it cherry-picked, please add a comment with If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add The currently active branches are now 18, 20, 21 and master. |
It's something to go off of, and there are more comments in the code that can be used if needed. |
This is why I suggested actually digging in more to truly understand the scenario and what is going on to provide a better and more helpful message in the correct situation. |
If chan_iax2 isn't listening on the particular loopback address, the packets are being sent somewhere and not actually getting processed, hence the lack of a valid call number at this point. Why it is that someone is trying to dial a loopback address that isn't being listened on is really their issue to resolve, but this should clue them in on that hopefully. |
On further looking, they were actually being received so my initial analysis was incorrect - why things went awry I don't know, but it was seemingly due to not explicitly binding. I don't think it's actually understood why it's doing what it is doing, beyond that binding explicitly causes it to work. |
f813231
to
4636198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be marked as fixing the associated issue. That issue should remain open.
Add a log message for a path that currently silently drops IAX2 frames without indicating that anything is wrong.
4636198
to
99f440f
Compare
@InterLinked1 Cherry-pick? |
cherry-pick-to: 20 |
d09359b
into
asterisk:master
Successfully merged to branch master and cherry-picked to ["20","21","22"] |
Add a log message for a path that currently silently drops IAX2 frames without indicating that anything is wrong.