manager.c: Fix erroneous reloads in UpdateConfig.#552
Merged
asterisk-org-access-app[bot] merged 1 commit intoJan 30, 2024
Merged
Conversation
Contributor
Author
|
cherry-pick-to: 18 |
github-actions
Bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
Contributor
|
This appears to be resolved in the most recent commit. |
Currently, a reload will always occur if the Reload header is provided for the UpdateConfig action. However, we should not be doing a reload if the header value has a falsy value, per the documentation, so this makes the reload behavior consistent with the existing documentation. Resolves: asterisk#551
InterLinked1
force-pushed
the
master-issue-551
branch
from
07a136f to
eabff1a
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-tests-failed
pr-submit-testing-in-progress
labels
jcolp
approved these changes
Jan 29, 2024
github-actions
Bot
added
cherry-pick-testing-in-progress
github-actions
Bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["18","20","21"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a reload will always occur if the
Reload header is provided for the UpdateConfig
action. However, we should not be doing a reload
if the header value has a falsy value, per the
documentation, so this makes the reload behavior
consistent with the existing documentation.
Resolves: #551