From 35f7f7b66df3b92fb77a8d20b290ff19d02b1681 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Mon, 20 Feb 2023 18:08:18 -0500 Subject: [PATCH] Avoid boolean-trap rules for positional-only builtin calls (#3075) --- .../ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py | 2 ++ crates/ruff/src/rules/flake8_boolean_trap/rules.rs | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py b/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py index 8b92fab6fba85..b4851257863cf 100644 --- a/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py +++ b/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py @@ -57,6 +57,8 @@ def used(do): {}.deploy(True, False) getattr(someobj, attrname, False) mylist.index(True) +int(True) +str(int(False)) class Registry: diff --git a/crates/ruff/src/rules/flake8_boolean_trap/rules.rs b/crates/ruff/src/rules/flake8_boolean_trap/rules.rs index 85547e8da6cd9..f7b33a14faecf 100644 --- a/crates/ruff/src/rules/flake8_boolean_trap/rules.rs +++ b/crates/ruff/src/rules/flake8_boolean_trap/rules.rs @@ -50,6 +50,10 @@ const FUNC_CALL_NAME_ALLOWLIST: &[&str] = &[ "pop", "setattr", "setdefault", + "str", + "bytes", + "int", + "float", ]; const FUNC_DEF_NAME_ALLOWLIST: &[&str] = &["__setitem__"];