-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pylint
] Implement potential-index-error
(PLE0643
)
#9545
Conversation
|
d411cd4
to
652603a
Compare
It's quite common to deal with int64 array indices in machine learning and big data applications so I would recommend allow 64bit indices. Seems like the speed difference wouldn't be worth improperly handling these edge cases? |
I'd love to see a way for arbitrary integer comparisons here, but I don't think we'll be able to do that without adding dependencies. I'd love to be proven wrong, but I'd also argue that 64 bits is beyond plenty in this scenario. |
12e059a
to
6ba0c85
Compare
e3af85a
to
59ed7ba
Compare
59ed7ba
to
9263644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
pylint
] - add potential-index-error
rule (PLE0643
)pylint
] Implement potential-index-error
(PLE0643
)
Great tweaks! |
Summary
add
potential-index-error
rule (PLE0643
)See: #970
Test Plan
cargo test