-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conditionalize more tests that require PyPI #13699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For |
For Lines 63 to 64 in de64f1d
For |
|
I see also that I made an error in This does need to be conditionalized on PyPI access somehow, but the |
|
We can expose the a |
Also require the python feature for it.
75a95f8 to
2d77f60
Compare
|
Rebased on |
CodSpeed Walltime Performance ReportMerging #13699 will improve performances by 15.79%Comparing Summary
Benchmarks breakdown
|
Summary
Use the existing
pypifeature to conditionalize a number of tests that attempt to access https://pypi.org and/or https://files.pythonhosted.org. See #8970 (comment).There is no reason to believe that these are all of the tests that need to be conditionalized on the
pypifeature, but this should be a solid step in the right direction.Test Plan
This allows me to build and run the integration tests in Fedora’s
uvpackage without having to manually skip tests that try to access PyPI. I confirmed that this appears to accomplish that goal.Otherwise, this should be tested by building and running the tests as usual. As mentioned in #8970 (comment), a more complete solution would include CI tests that confirm these features are working as intended. I’m not in a position to offer that.