Fix: Socksify::Debug = false enables debug output

Thanks @dblommesteijn
astro · Mar 13, 2018 · b200931 · b200931
1 parent d13fd2b
commit b200931
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -66,3 +66,10 @@ SOCKSify Ruby 1.7.1
 * Send requests in one call
   For compatibility with shadowsocks <=3.0.3
   (thanks to Yilin Chen)
+
+unreleased
+SOCKSify Ruby 1.7.2
+===================
+* Fix Socksify::debug = false
+  Previously, debug was enabled if any value was assigned to Socksify::debug
+  (thanks to Dennis Blommesteijn)
diff --git a/lib/socksify/debug.rb b/lib/socksify/debug.rb
@@ -44,7 +44,7 @@ def self.debug_error(str)
   private
 
   def self.debug(color, str)
-    if defined? @@debug
+    if defined?(@@debug) && @@debug
       puts "#{color}#{now_s}#{Color::Reset} #{str}"
     end
   end