Migrate all Deployment Commands to Core #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandyliu
approved these changes
Jan 16, 2024
cmd/cloud/deployment.go
Outdated
| @@ -185,10 +189,10 @@ func newDeploymentUpdateCmd(out io.Writer) *cobra.Command { | |||
| cmd.Flags().IntVarP(&updateSchedulerAU, "scheduler-au", "s", 0, "The Deployment's Scheduler resources in AUs") | |||
| cmd.Flags().IntVarP(&updateSchedulerReplicas, "scheduler-replicas", "r", 0, "The number of Scheduler replicas for the Deployment") | |||
| cmd.Flags().BoolVarP(&forceUpdate, "force", "f", false, "Force update: Don't prompt a user before Deployment update") | |||
| cmd.Flags().StringVarP(&cicdEnforcement, "enforce-cicd", "", "", "When enabled CI/CD Enforcement where deploys to deployment must use an API Key or Token. This essentially forces Deploys to happen through CI/CD. Possible values disable/enable") | |||
There was a problem hiding this comment.
This seems like a breaking change? Any reason we are changing this?
| if organization.IsOrgHosted() { | ||
| cmd.Flags().StringVarP(&clusterType, "cluster-type", "", standard, "The Cluster Type to use for the Deployment. Possible values can be standard or dedicated.") | ||
| cmd.Flags().StringVarP(&deploymentType, "type", "", standard, "The Type to use for the Deployment. Possible values can be standard or dedicated.") |
There was a problem hiding this comment.
This too...is there a way for us to support both, so we dont break any customer automations that use the old flag?
| // update deployment | ||
| environmentVariablesObjects, err := client.ModifyDeploymentVariable(variablesCreateInput) | ||
| err = Update(currentDeployment.Id, "", "", "", "", "", "", "", "", "", "", "", "", "", 0, 0, []astroplatformcore.WorkerQueueRequest{}, []astroplatformcore.HybridWorkerQueueRequest{}, newEnvironmentVariables, false, coreClient, platformCoreClient) |
There was a problem hiding this comment.
Not in this PR, but we need to improve the Update function with a proper input and validations. This request with so many input arguments looks bad and prone to errors.
cloud/deploy/deploy.go
Outdated
| @@ -286,13 +287,17 @@ func Deploy(deployInput InputDeploy, client astro.Client, coreClient astrocore.C | |||
| } | |||
|
|
|||
| if !deployInfo.dagDeployEnabled { | |||
| fmt.Println("deployment id:") | |||
There was a problem hiding this comment.
Can we remove these debug prints?
cloud/deploy/deploy.go
Outdated
| if err != nil { | ||
| if strings.Contains(err.Error(), dagDeployDisabled) { | ||
| fmt.Println("deployment id:") |
There was a problem hiding this comment.
Can we remove these debug prints?
cloud/deploy/deploy.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| fmt.Println("CI/CD enforcement:") |
There was a problem hiding this comment.
Are these debug prints?
| } | ||
|
|
||
| func IsDeploymentStandard(deploymentType astroplatformcore.DeploymentType) bool { | ||
| return deploymentType == astroplatformcore.DeploymentTypeSTANDARD |
There was a problem hiding this comment.
For old deployment templates files, we had a type HOSTED_SHARED. We should also support that, so as to not break those deployment via a file.
cloud/deploy/deploy.go
Outdated
| if err != nil { | ||
| if strings.Contains(err.Error(), dagDeployDisabled) { | ||
| fmt.Println(deployInfo.deploymentID) |
cloud/deploy/deploy.go
Outdated
| @@ -286,13 +285,15 @@ func Deploy(deployInput InputDeploy, client astro.Client, coreClient astrocore.C | |||
| } | |||
|
|
|||
| if !deployInfo.dagDeployEnabled { | |||
| fmt.Println(deployInfo.deploymentID) | |||
kushalmalani
approved these changes
Jan 23, 2024
ashb
added a commit
that referenced
this pull request
Feb 20, 2024
After the migration to the REST API in #1425 it wasn't dealing with secret variables (which don't have a value anymore). And while I'm there do a bit of tidying up: - `_, x := range` instead of slice index access - Remove the use of `environmentVariablesObjects` global variable! - Refactoring of selecting the variable key to one place only (rather than in multiple)
8 tasks
ashb
added a commit
that referenced
this pull request
Feb 21, 2024
After the migration to the REST API in #1425 it wasn't dealing with secret variables (which don't have a value anymore). And while I'm there do a bit of tidying up: - `_, x := range` instead of slice index access - Remove the use of `environmentVariablesObjects` global variable! - Refactoring of selecting the variable key to one place only (rather than in multiple)
ashb
added a commit
that referenced
this pull request
Feb 21, 2024
After the migration to the REST API in #1425 it wasn't dealing with secret variables (which don't have a value anymore). And while I'm there do a bit of tidying up: - `_, x := range` instead of slice index access - Remove the use of `environmentVariablesObjects` global variable! - Refactoring of selecting the variable key to one place only (rather than in multiple)
kushalmalani
pushed a commit
that referenced
this pull request
Feb 21, 2024
After the migration to the REST API in #1425 it wasn't dealing with secret variables (which don't have a value anymore). And while I'm there do a bit of tidying up: - `_, x := range` instead of slice index access - Remove the use of `environmentVariablesObjects` global variable! - Refactoring of selecting the variable key to one place only (rather than in multiple)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
migrate the following commands to Astro CORE API:
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
manually tested all commands with hybrid/hosted/kubernetes/celery Deployments
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft