fix env var output #1507
Merged
fix env var output #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1507 +/- ##
=======================================
Coverage 85.90% 85.91%
=======================================
Files 112 112
Lines 14847 14850 +3
=======================================
+ Hits 12755 12758 +3
Misses 1254 1254
Partials 838 838 ☔ View full report in Codecov by Sentry. |
| varTab.AddRow([]string{strconv.Itoa(index), environmentVariablesObjects[i].Key, *environmentVariablesObjects[i].Value, strconv.FormatBool(environmentVariablesObjects[i].IsSecret)}, false) | ||
| printValue := notApplicable | ||
| if environmentVariablesObjects[i].Value != nil { | ||
| printValue = *environmentVariablesObjects[i].Value |
There was a problem hiding this comment.
Do we need to add test cases here considering our previous set of test cases didnt catch the error?
vandyliu
approved these changes
Feb 1, 2024
kushalmalani
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix problem causing
astro deployment variable update/create --secretto end in a segmentation error. The value coming from the API was null so the print statement at the end of the command was getting a panic error. This PR makes it so the value prints as N/A when it is null. The variable value is null because it is secret🎟 Issue(s)
Related #XXX
🧪 Functional Testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft