Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed deployment type msg from dag_only to dag_deploy #1528

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

rujhan-arora-astronomer
Copy link
Contributor

@rujhan-arora-astronomer rujhan-arora-astronomer commented Feb 6, 2024

Description

Changed deployment type msg from dag_only to dag_deploy

🎟 Issue(s)

Related #6119

🧪 Functional Testing

locally

📸 Screenshots

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1066e0) 85.96% compared to head (1119a62) 85.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1528   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         112      112           
  Lines       14962    14962           
=======================================
  Hits        12862    12862           
  Misses       1265     1265           
  Partials      835      835           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neel-astro neel-astro merged commit 22ca8f6 into main Feb 6, 2024
5 checks passed
@neel-astro neel-astro deleted the 6119_v2 branch February 6, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants