fix worker-queue update #1531
Merged
fix worker-queue update #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkickr
requested review from
neel-astro,
kushalmalani and
vandyliu
as code owners
vandyliu
reviewed
Feb 6, 2024
| assert.Equal(t, int(mockWorkerQueueDefaultOptions.MaxWorkers.Default), actualQueue.MaxWorkerCount) | ||
| }) | ||
| t.Run("sets default worker concurrency for queue if user did not provide it", func(t *testing.T) { | ||
| actualQueue := SetWorkerQueueValues(10, 150, 0, mockWorkerQueue, mockWorkerQueueDefaultOptions) | ||
| actualQueue := SetWorkerQueueValues(10, 150, 0, mockWorkerQueue, mockWorkerQueueDefaultOptions, mockMachineOptions) |
There was a problem hiding this comment.
for this test are workerQueueDefaultOptions.WorkerConcurrency.Default and machineOptions.Concurrency.Default the same value so it wasn't caught?
There was a problem hiding this comment.
I don't think if they were different values it would be caught. workerQueueDefaultOptions.WorkerConcurrency.Default is only used by hybrid and machineOptions.Concurrency.Default. But SetWorkerQueueValues was setup assuming that they both use workerQueueDefaultOptions.WorkerConcurrency.Default and the tests were setup to reflect that. Just need to make sure that SetWorkerQueueValues uses mockMachineOptions for hosted deployments which the tests do now
kushalmalani
approved these changes
Feb 6, 2024
kushalmalani
pushed a commit
that referenced
this pull request
Feb 7, 2024
* fix worker-queue update * fix lint * fix test * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Worker queue update command was using worker concurrency default values for hybrid when it should be using the value for hosted.
🎟 Issue(s)
🧪 Functional Testing
manual testing
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft