Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying workload identity at deployment create time #1550

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

jlaneve
Copy link
Contributor

@jlaneve jlaneve commented Feb 14, 2024

Description

This PR adds support for a new field, Workload Identity, on deployment create time. The corresponding API change has been merged and goes out next week.

There is a change in behavior for deployment yaml files / deployments as code:

  • the deployment yaml file has two sections: config (can be edited) and metadata (can't be edited). so this PR moves workload ID from metadata to config
  • if I have it set up today without the workload ID field in config section, it still works. so if a user wants to start using this workload ID with a pre-existing yaml file, they just need to move the field themselves

🎟 Issue(s)

n/a

🧪 Functional Testing

Built the CLI locally and ran against dev.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2fdacf7) 86.14% compared to head (d86a4f9) 86.16%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1550      +/-   ##
==========================================
+ Coverage   86.14%   86.16%   +0.01%     
==========================================
  Files         112      112              
  Lines       14945    14952       +7     
==========================================
+ Hits        12874    12883       +9     
+ Misses       1252     1251       -1     
+ Partials      819      818       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Show resolved Hide resolved
@jlaneve jlaneve marked this pull request as ready for review February 14, 2024 15:27
Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change is simple enough and unit test looks good
plus tested against dev env

@sunkickr
Copy link
Contributor

should we add a --workload-identity flag to astro deployment create/update?

Copy link
Contributor

@sunkickr sunkickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunkickr sunkickr merged commit f47a24a into main Feb 16, 2024
5 checks passed
@sunkickr sunkickr deleted the workload-identity-dep-create branch February 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants