-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying workload identity at deployment create time #1550
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1550 +/- ##
==========================================
+ Coverage 86.14% 86.16% +0.01%
==========================================
Files 112 112
Lines 14945 14952 +7
==========================================
+ Hits 12874 12883 +9
+ Misses 1252 1251 -1
+ Partials 819 818 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change is simple enough and unit test looks good
plus tested against dev env
should we add a |
2438d87
to
a89728c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR adds support for a new field, Workload Identity, on deployment create time. The corresponding API change has been merged and goes out next week.
There is a change in behavior for deployment yaml files / deployments as code:
🎟 Issue(s)
n/a
🧪 Functional Testing
Built the CLI locally and ran against dev.
📸 Screenshots
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft