Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont write workload identity to yaml file on deployment inspect #1565

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

melugoyal
Copy link
Contributor

Description

Describe the purpose of this pull request.

don't write workload identity to yaml file on deployment inspect. this was breaking the flow of:

  1. astro deployment inspect on an existing deployment
  2. modify file with new deployment config
  3. create deployment

the breakage was happening because the new deployment's create payload would contain the Workload Identity from the previous deployment. instead we can leave the value empty upon astro deployment inspect, and the API will default it. if someone has an override to pass in, they can enter it in the deployments-as-code file.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (57f4ae5) to head (1c3c443).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
- Coverage   86.41%   86.41%   -0.01%     
==========================================
  Files         113      113              
  Lines       15670    15668       -2     
==========================================
- Hits        13542    13540       -2     
  Misses       1280     1280              
  Partials      848      848              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalmalani kushalmalani merged commit 81b3793 into main Feb 22, 2024
4 of 5 checks passed
@kushalmalani kushalmalani deleted the fix-inspect-e2e branch February 22, 2024 22:20
kushalmalani pushed a commit that referenced this pull request Feb 23, 2024
* dont write workload identity to yaml file on deployment inspect

* fix unit tests

---------

Co-authored-by: Julian LaNeve <lanevejulian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants