Add the ability to interact between local dataframes and Delta tables… #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.91% // Head: 97.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1397 +/- ##
==========================================
+ Coverage 88.91% 97.32% +8.41%
==========================================
Files 60 19 -41
Lines 3120 672 -2448
Branches 368 0 -368
==========================================
- Hits 2774 654 -2120
+ Misses 252 18 -234
+ Partials 94 0 -94 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dimberman
requested review from
tatiana,
utkarsharma2,
sunank200,
pankajastro,
pankajkoti and
feluelle
as code owners
kaxil
reviewed
Dec 12, 2022
kaxil
reviewed
Dec 12, 2022
kaxil
reviewed
Dec 12, 2022
kaxil
approved these changes
Dec 12, 2022
tatiana
reviewed
Dec 12, 2022
tatiana
reviewed
Dec 12, 2022
tatiana
reviewed
Dec 12, 2022
tatiana
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
Thanks @dimberman, I'm happy for this to be merged once:
- row limit is -1 by default (and that is when it is unlimited)
- we remove Postgres from the test name
kaxil
reviewed
Dec 14, 2022
dimberman
force-pushed
the
spark-dataframe-interaction
branch
from
25a4a81
to
ea5fe75
Compare
dimberman
force-pushed
the
spark-dataframe-interaction
branch
from
ea5fe75
to
ea4f424
Compare
…pushing local dataframes into spark delta tables
dimberman
force-pushed
the
spark-dataframe-interaction
branch
from
ea4f424
to
b206bb5
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in databricks
Description
Currently there is no established path for moving a dataframe into a databricks delta table except to manually save that dataframe as a local file and then push that file into delta using aql.load_file.
What is the new behavior?
This PR allows users to pass local dataframes into delta files using all of the existing methods withing the astro SDK (e.g. passing it into a transform function). Users should not need to learn any new functionality as all of this will work out of the box with existing aql based DAGs.
Does this introduce a breaking change?
No.
Checklist