Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken scan-docker-images CI job #2099

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Conversation

danielhoherd
Copy link
Member

Description

  • Use cimg/base:current-22.04
  • use /usr/bin/bash for shell
  • move shell options to their own step

Related Issues

https://github.com/astronomer/issues/issues/6125

Testing

This should be manually tested. It only affects dev workflows, not the product itself.

Merging

This should be merged everywhere

@danielhoherd danielhoherd requested a review from a team as a code owner February 1, 2024 16:49
@rishkarajgi rishkarajgi self-requested a review February 1, 2024 17:07
@pgvishnuram
Copy link
Contributor

bin/trivy-scan.sh: line 22: trivy: command not found

@pgvishnuram pgvishnuram merged commit a98e225 into master Feb 1, 2024
24 of 38 checks passed
@pgvishnuram pgvishnuram deleted the 6125-fix-scan-docker-images branch February 1, 2024 18:23
pgvishnuram added a commit that referenced this pull request Feb 1, 2024
* Use cimg/base:current-22.04, use /usr/bin/bash, and move shell options to their own step.

* Fix code typo

* remove curl package command

* fix trivy

* remove commands

* add sudo for trivycli copy

---------

Co-authored-by: pgvishnuram <vishnu@astronomer.io>
danielhoherd added a commit that referenced this pull request Feb 6, 2024
* Use cimg/base:current-22.04, use /usr/bin/bash, and move shell options to their own step.

* Fix code typo

* remove curl package command

* fix trivy

* remove commands

* add sudo for trivycli copy

---------

Co-authored-by: pgvishnuram <vishnu@astronomer.io>
danielhoherd added a commit that referenced this pull request Feb 6, 2024
* Use cimg/base:current-22.04, use /usr/bin/bash, and move shell options to their own step.

* Fix code typo

* remove curl package command

* fix trivy

* remove commands

* add sudo for trivycli copy

---------

Co-authored-by: pgvishnuram <vishnu@astronomer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants