-
Notifications
You must be signed in to change notification settings - Fork 9
LSDB.nested catalog generation #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click here to view all benchmarks. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 97.20% 97.31% +0.11%
==========================================
Files 53 53
Lines 2253 2312 +59
==========================================
+ Hits 2190 2250 +60
+ Misses 63 62 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 tasks
|
One failed test on the windows side that seems unrelated... |
Allow PixelSearch in generate_catalog
delucchi-cmu
reviewed
May 5, 2025
delucchi-cmu
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #722
Closes #730
Modifies generate_data with ra/dec & and integer id column
Adds generate_catalog one-liner
Allows use of search_filters like in to_hats to control spatial region of generated data. Currently supports BoxSearch (equivalent to just using ra_range and dec_range) and ConeSearch
Removes generate_parquet_file because it's not really relevant to LSDB
These functions are currently found in the import structure as:
Is there a better place for these?