Skip to content

Conversation

@olivialynn
Copy link
Member

Closes #663

  • Removes now-redundant notebook sections (described in issue)
  • Renames to filtering_large_catalogs .ipynb → column_filtering.ipynb
  • Adds new explanation on column filtering

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented May 19, 2025

Before [80ea0a6] After [29bee3b] Ratio Benchmark (Parameter)
13.6±0.2ms 14.1±0.5ms 1.04 benchmarks.time_box_filter_on_partition
83.7±2ms 86.1±0.9ms 1.03 benchmarks.time_kdtree_crossmatch
6.25±0.02s 6.29±0.04s 1.01 benchmarks.time_create_large_catalog
944±6ms 946±10ms 1 benchmarks.time_create_midsize_catalog
28.5±0.3ms 28.3±1ms 0.99 benchmarks.time_polygon_search

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (80ea0a6) to head (42e62eb).
⚠️ Report is 203 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          54       54           
  Lines        2461     2461           
=======================================
  Hits         2398     2398           
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olivialynn olivialynn requested a review from delucchi-cmu May 19, 2025 22:22
@olivialynn olivialynn merged commit b171ad3 into main May 21, 2025
13 checks passed
@olivialynn olivialynn deleted the issue/663/docs-filtering-large-catalogs branch May 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise "1.3 Column filtering (e.g. columns=)" (aka "Filtering large catalogs")

3 participants