Skip to content

Conversation

@camposandro
Copy link
Collaborator

Reset the default columns for a catalog saved with to_hats, unless they are specified by the user. Closes #786.

@camposandro camposandro requested a review from smcguire-cmu June 2, 2025 20:25
@camposandro camposandro self-assigned this Jun 2, 2025
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

Before [7e1ac78] <v0.5.3> After [d8be8c2] Ratio Benchmark (Parameter)
6.28±0.03s 6.34±0.01s 1.01 benchmarks.time_create_large_catalog
934±8ms 940±7ms 1.01 benchmarks.time_create_midsize_catalog
26.8±0.5ms 27.1±0.4ms 1.01 benchmarks.time_polygon_search
13.1±0.09ms 12.9±0.2ms 0.99 benchmarks.time_box_filter_on_partition
81.4±2ms 80.2±0.7ms 0.98 benchmarks.time_kdtree_crossmatch

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (af44d09) to head (57b9a97).
⚠️ Report is 180 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          54       54           
  Lines        2463     2464    +1     
=======================================
+ Hits         2400     2401    +1     
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astronomy-commons astronomy-commons deleted a comment from camposandro Jun 6, 2025
@camposandro camposandro merged commit 59d7690 into main Jun 6, 2025
13 checks passed
@camposandro camposandro deleted the issue/786/xmatch-default-cols branch June 6, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crossmatched catalogs display only one catalog's columns by default when read

3 participants