Skip to content

Conversation

@hombit
Copy link
Contributor

@hombit hombit commented Jun 30, 2025

No description provided.

@hombit hombit requested a review from dougbrn June 30, 2025 20:22
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hombit hombit enabled auto-merge June 30, 2025 20:22
@github-actions
Copy link

Before [1176de6] After [ab44f10] Ratio Benchmark (Parameter)
38.4±0.5ms 39.0±0.8ms 1.02 benchmarks.time_polygon_search
924±5ms 931±4ms 1.01 benchmarks.time_create_midsize_catalog
80.9±1ms 81.4±1ms 1.01 benchmarks.time_kdtree_crossmatch
24.3±0.3ms 24.3±0.3ms 1 benchmarks.time_box_filter_on_partition
6.23±0.02s 6.25±0.07s 1 benchmarks.time_create_large_catalog

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (1176de6) to head (44ad774).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          54       54           
  Lines        2570     2570           
=======================================
  Hits         2447     2447           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one sanity check question. And maybe run black on it to fix the pre-commit fails

@hombit hombit merged commit 4f5232d into main Jun 30, 2025
12 of 13 checks passed
@hombit hombit deleted the update-des-gaia branch June 30, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants